mirror of
https://git.suyu.dev/suyu/breakpad.git
synced 2025-12-25 00:35:04 +01:00
ef04c9c028
Since target_ptr is of type uint16_t* already, we don't need to scale the byte count as the language does that for us. If it were void*, we would need this code, but it's not. In practice it's probably not a big deal due to how we preallocated memory: when converting UTF8->UTF16, we'd reserve the same number of code units, and UTF8 takes more code units per codepoint than UTF16, so the UTF16 vector is always oversized. When converting UTF32->UTF16, we also reserve the same number of code units, but since one UTF32 code unit could require two UTF16 code units (for U+10000 codepoints and higher), we would probably corrupt memory in the process. The APIs in this module don't seem to take into account that range in general, so for now I'm only fixing the memory corruption. Bug: google-breakpad:768 Change-Id: Ibfaea4e866733ff8d99b505e72c500bd40d11a74 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1732888 Reviewed-by: Mark Mentovai <mark@chromium.org> |
||
|---|---|---|
| .. | ||
| android | ||
| dwarf | ||
| linux | ||
| mac | ||
| solaris | ||
| testdata | ||
| tests | ||
| windows | ||
| basictypes.h | ||
| byte_cursor.h | ||
| byte_cursor_unittest.cc | ||
| common.gyp | ||
| convert_UTF.c | ||
| convert_UTF.h | ||
| dwarf_cfi_to_module.cc | ||
| dwarf_cfi_to_module.h | ||
| dwarf_cfi_to_module_unittest.cc | ||
| dwarf_cu_to_module.cc | ||
| dwarf_cu_to_module.h | ||
| dwarf_cu_to_module_unittest.cc | ||
| dwarf_line_to_module.cc | ||
| dwarf_line_to_module.h | ||
| dwarf_line_to_module_unittest.cc | ||
| dwarf_range_list_handler.cc | ||
| dwarf_range_list_handler.h | ||
| language.cc | ||
| language.h | ||
| long_string_dictionary.cc | ||
| long_string_dictionary.h | ||
| long_string_dictionary_unittest.cc | ||
| md5.cc | ||
| md5.h | ||
| memory_allocator.h | ||
| memory_allocator_unittest.cc | ||
| memory_range.h | ||
| memory_range_unittest.cc | ||
| minidump_type_helper.h | ||
| module.cc | ||
| module.h | ||
| module_unittest.cc | ||
| path_helper.cc | ||
| path_helper.h | ||
| scoped_ptr.h | ||
| simple_string_dictionary.cc | ||
| simple_string_dictionary.h | ||
| simple_string_dictionary_unittest.cc | ||
| stabs_reader.cc | ||
| stabs_reader.h | ||
| stabs_reader_unittest.cc | ||
| stabs_to_module.cc | ||
| stabs_to_module.h | ||
| stabs_to_module_unittest.cc | ||
| stdio_wrapper.h | ||
| string_conversion.cc | ||
| string_conversion.h | ||
| string_conversion_unittest.cc | ||
| symbol_data.h | ||
| test_assembler.cc | ||
| test_assembler.h | ||
| test_assembler_unittest.cc | ||
| unordered.h | ||
| using_std_string.h | ||