mirror of
https://git.suyu.dev/suyu/breakpad.git
synced 2025-12-26 17:25:04 +01:00
615d2c0d6d
Inspector::ReadMessages as was done before r627. The "hello" message contains the parameter count and is referenced while the message reader loops through parameter messages. Prior to r627, both messages were named |message|, which was confusing, probably caused a compiler warning, and apparently provided the motivation to share them. This caused the crash inspector to fail to properly collect the parameters. The common failure mode (although others are possible) was for the inspector to attempt tor read more parameter messages than were available, resulting in an IPC timeout and inspector death. No crash report would be written, and the application expecting its crash to be inspected would time out waiting for a response from the inspector and then _exit. This is effectively a failure to properly handle crashes. The inner message is reintroduced, and named parameter_message for disambiguation. BUG=chromium:49821 TEST=Crashes catchable by the Mac Breakpad framework Review URL: http://breakpad.appspot.com/123002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@628 4c0a9323-5329-0410-9bdc-e9ce6186880e |
||
|---|---|---|
| .. | ||
| linux | ||
| mac | ||
| solaris/handler | ||
| windows | ||
| minidump_file_writer-inl.h | ||
| minidump_file_writer.cc | ||
| minidump_file_writer.h | ||
| minidump_file_writer_unittest.cc | ||