Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2025-12-24 08:15:01 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
breakpad/src/common
History
Ted Mielczarek 2e266396ee Fix DWARF handling of inlined functions in namespaces 
Currently an inlined function in a namespace in DWARF will
be given a name comprised of just `namespace::`. This is due
to a logic error in ComputeQualifiedName, where it doesn't
handle an empty `unqualified_name` properly.

We apparently have a fair number of these in our Mac builds,
an example of the DWARF that's being mishandled looks like:
0x117eda40:     TAG_namespace [5] *
                 AT_name( "js" )
                 AT_decl_file( "../../dist/include/js/Utility.h" )
                 AT_decl_line( 35 )

0x11808500:         TAG_subprogram [251] *
                     AT_low_pc( 0x0000000002f12110 )
                     AT_high_pc( 0x0000000002f1216b )
                     AT_APPLE_omit_frame_ptr( 0x01 )
                     AT_frame_base( rsp )
                     AT_abstract_origin( {0x0000000011800a4f}"_ZN2js40TraceManuallyBarrieredGenericPointerEdgeEP8JSTracerPPNS_2gc4CellEPKc" )
                      AT_MIPS_linkage_name( "_ZN2js40TraceManuallyBarrieredGenericPointerEdgeEP8JSTracerPPNS_2gc4CellEPKc" )
                      AT_name( "TraceManuallyBarrieredGenericPointerEdge" )
                      AT_decl_file( "/builds/slave/rel-m-rel-m64_bld-000000000000/build/js/src/gc/Marking.cpp" )
                      AT_decl_line( 547 )
                      AT_external( 0x01 )
                      AT_APPLE_optimized( 0x01 )
                      AT_inline( DW_INL_inlined )

This turned a few instances of this in the file I was testing on into
`<name omitted>`, which seems to just be a symptom of the
"DW_AT_abstract_origin comes later in the file" issue. (Which is probably
also worth fixing given that it occurs some 29k times when dumping
symbols from Firefox's XUL binary, but it's a separate issue.)

R=mark@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1887033002 .
2016-04-14 10:32:20 -04:00
..
android [mips64] Support for mips n64 2016-02-06 18:58:39 -05:00
dwarf convert to uint8_t* for binary data to fix -Wnarrowing build errors 2016-01-26 15:38:19 -05:00
linux tweak IGNORE_RET behavior a bit 2016-04-11 13:05:44 -04:00
mac Added an option (-i) to have dump_syms output header information only. 2016-04-08 04:37:45 +02:00
solaris solaris: fix spurious ; 2015-09-11 12:59:53 -04:00
testdata
tests Add missing #include of eintr_wrapper.h to auto_testfile.h. Since it's 2013-12-03 19:01:17 +00:00
windows Fix format warning in omap.cc 2016-03-10 08:51:20 -05:00
basictypes.h Use a proper ignore_result() to fix a ftruncate warn_unused_result warning with GCC 4.8. 2013-12-18 19:52:36 +00:00
byte_cursor.h This change allows compiling the google-breakpad code using a global ::string class instead of std::string. For more details take a look at common/using_std_string.h 2012-06-28 22:46:01 +00:00
byte_cursor_unittest.cc This change allows compiling the google-breakpad code using a global ::string class instead of std::string. For more details take a look at common/using_std_string.h 2012-06-28 22:46:01 +00:00
common.gyp Improvements to GYP build 2016-01-29 11:43:21 +00:00
convert_UTF.c Update license on convert_UTF.* to the standard Unicode license. 2015-02-25 21:16:43 +00:00
convert_UTF.h Update license on convert_UTF.* to the standard Unicode license. 2015-02-25 21:16:43 +00:00
dwarf_cfi_to_module.cc Add Arm64 support to dumpsyms. 2014-04-29 09:45:46 +00:00
dwarf_cfi_to_module.h Add Arm64 support to dumpsyms. 2014-04-29 09:45:46 +00:00
dwarf_cfi_to_module_unittest.cc Add some more DWARF ARM register numbers to the DWARF CFI register maps 2012-07-18 18:13:29 +00:00
dwarf_cu_to_module.cc Fix DWARF handling of inlined functions in namespaces 2016-04-14 10:32:20 -04:00
dwarf_cu_to_module.h convert to uint8_t* for binary data to fix -Wnarrowing build errors 2016-01-26 15:38:19 -05:00
dwarf_cu_to_module_unittest.cc Fix DWARF handling of inlined functions in namespaces 2016-04-14 10:32:20 -04:00
dwarf_line_to_module.cc Include the compilation directory for FILE entries, making them absolute instead of relative 2013-01-23 18:01:28 +00:00
dwarf_line_to_module.h Include the compilation directory for FILE entries, making them absolute instead of relative 2013-01-23 18:01:28 +00:00
dwarf_line_to_module_unittest.cc Include the compilation directory for FILE entries, making them absolute instead of relative 2013-01-23 18:01:28 +00:00
language.cc
language.h Fixing various compiler warnings and applying minor tweaks to allow running of 2012-07-02 22:55:57 +00:00
md5.cc Fixup breakpad compile for Xcode 5.1 iOS release 2014-02-24 21:35:40 +00:00
md5.h Fix up ~14 warnings about 'Implicit conversion loses integer precision' on iOS. 2014-02-18 22:52:02 +00:00
memory.h Switch the Linux minidump writer to use MDCVInfoELF for CV data. 2016-04-05 09:34:20 -04:00
memory_range.h Use stdint types everywhere 2013-03-06 14:04:42 +00:00
memory_range_unittest.cc Use stdint types everywhere 2013-03-06 14:04:42 +00:00
memory_unittest.cc Switch the Linux minidump writer to use MDCVInfoELF for CV data. 2016-04-05 09:34:20 -04:00
minidump_type_helper.h Remove pointers from serialized file format 2014-12-11 01:17:43 +00:00
module.cc Handle ARM THUMB functions when removing duplicate PUBLIC entries. 2015-02-03 23:13:04 +00:00
module.h Fix some fragile code that is likely to cause future memory corruption 2015-01-27 01:20:59 +00:00
module_unittest.cc Add unit tests for overlapping functions and externs. 2015-02-04 00:03:58 +00:00
scoped_ptr.h Switch scoped_ptr.h to a compatible google3 implementation. 2013-12-18 19:49:55 +00:00
simple_string_dictionary.cc Rewrite SimpleStringDictionary with NonAllocatingMap. 2013-04-24 18:15:48 +00:00
simple_string_dictionary.h In NonAllocatingMap, remove asserts around key/value length. 2013-10-01 21:32:16 +00:00
simple_string_dictionary_unittest.cc In NonAllocatingMap, remove asserts around key/value length. 2013-10-01 21:32:16 +00:00
stabs_reader.cc This change allows compiling the google-breakpad code using a global ::string class instead of std::string. For more details take a look at common/using_std_string.h 2012-06-28 22:46:01 +00:00
stabs_reader.h Fix Mac Breakpad host tools to build in Linux cross-compile 2015-09-16 06:46:55 -04:00
stabs_reader_unittest.cc Use stdint types everywhere 2013-03-06 14:04:42 +00:00
stabs_to_module.cc Fix some fragile code that is likely to cause future memory corruption 2015-01-27 01:20:59 +00:00
stabs_to_module.h This change allows compiling the google-breakpad code using a global ::string class instead of std::string. For more details take a look at common/using_std_string.h 2012-06-28 22:46:01 +00:00
stabs_to_module_unittest.cc
stdio_wrapper.h Rename stdio.h wrapper file to stdio_wrapper.h. 2016-04-05 15:45:30 -04:00
string_conversion.cc Switch to scoped_array instead of inappropriate scoped_ptr. 2013-10-28 23:39:43 +00:00
string_conversion.h Use stdint types everywhere 2013-03-06 14:04:42 +00:00
symbol_data.h Allow reading just CFI data when reading symbols 2013-03-06 15:32:53 +00:00
test_assembler.cc Use stdint types everywhere 2013-03-06 14:04:42 +00:00
test_assembler.h Use stdint types everywhere 2013-03-06 14:04:42 +00:00
test_assembler_unittest.cc Use stdint types everywhere 2013-03-06 14:04:42 +00:00
unordered.h Both std::tr1::unordered_set and std::unordered_set are not allowed in 2014-07-21 18:27:43 +00:00
using_std_string.h This change allows compiling the google-breakpad code using a global ::string class instead of std::string. For more details take a look at common/using_std_string.h 2012-06-28 22:46:01 +00:00