Jon Turney
1f1d950d6a
Fix compilation of http_upload.cc with Windows gcc
...
Fix compilation of http_upload.cc with Windows gcc after 548ca6e3 , by
moving the definition of GetFileContents(), so it comes after the
definition of WideToMBCP(), which it uses (under !_MSC_VER).
common/windows/http_upload.cc: In function ‘bool {anonymous}::GetFileContents(const wstring&, std::vector<char>*)’:
common/windows/http_upload.cc:80:19: error: ‘WideToMBCP’ was not declared in this scope
Change-Id: I1646b39263e97bbf3bd8cb1ae209be238023110f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1928929
Reviewed-by: Mike Frysinger <vapier@chromium.org>
2019-11-22 18:29:21 +00:00
Nelson Billing
548ca6e382
Port new symbol upload API to Windows symupload tool.
...
- CL for Linux change, including new documentation for API, at:
https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1422400/3
Change-Id: I579744fec74c64757b8bc31de63d7a07ef9a0f1f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1487982
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
2019-06-12 20:56:37 +00:00
David Major
7685dfc567
Support for multiple upload files in CrashReportSender/HTTPUpload
...
A=David Major <dmajor@mozilla.com>
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1048091
R=ted@mielczarek.org
Review URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1048091 .
2015-10-06 11:05:12 -04:00
ted.mielczarek@gmail.com
c971cf439c
Fix Windows client compilation on mingw.
...
A=Jacek Caban <jacek@codeweavers.com>, R=ted at http://breakpad.appspot.com/548002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1399 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-11-03 17:05:39 +00:00
mark@chromium.org
a58de86bcd
Back out trunk r1367.
...
Compile error: https://bugzilla.mozilla.org/show_bug.cgi?id=1048091#c15
Review URL: https://breakpad.appspot.com/9694002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1369 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-09-03 13:40:40 +00:00
ted.mielczarek@gmail.com
8cde5c5152
Support for multiple upload files in CrashReportSender/HTTPUpload
...
A=David Major <dmajor@mozilla.com> R=ted at https://bugzilla.mozilla.org/show_bug.cgi?id=1048091
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1367 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-08-28 15:26:59 +00:00
ivan.penkov@gmail.com
6b46d4e872
Treat warnings as error and fix most level 4 warnings in the breakpad windows client projects.
...
Some of the lint errors in the files touched by this change were also fixed.
BUG=533
Review URL: https://breakpad.appspot.com/601002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1189 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-06-04 16:51:01 +00:00
ted.mielczarek
cd77197264
Fix sizeof bug in HTTPUpload::SendRequest
...
A=Himanshu <only4coding@gmail.com> R=ted at https://bugzilla.mozilla.org/show_bug.cgi?id=710993
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@992 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-07-20 17:54:32 +00:00
ted.mielczarek@gmail.com
7405ecd046
allow uploading zero-byte files in HTTPUpload
...
R=mark at http://breakpad.appspot.com/243001/show
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@743 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-12-15 16:19:32 +00:00
erikwright@chromium.org
7fde9a879d
Revert revision 658 ('Add glog style logging to symupload').
...
R=nealsid at http://breakpad.appspot.com/190001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@685 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-09-15 17:38:03 +00:00
ted.mielczarek
3b7d8ee362
Disable cookies in Windows HTTPUpload
...
R=nealsid at http://breakpad.appspot.com/161001/show
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@661 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-08-20 12:19:38 +00:00
nealsid@gmail.com
e167e9e61f
Add glog style logging to symupload
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@658 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-08-19 21:53:35 +00:00
nealsid
2a4698319a
Fix up warnings when building http_upload.cc. Changed warning level to /W4, and also turned off deprecated 64-bit compatability warning flag(since some people are regularly building Breakpad in 64-bit mode, if we turn off this flag we get rid of a warning in 32 bit mode under VS2008)
...
R=mmentovai
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@340 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-27 16:54:23 +00:00
nealsid
3366749ee7
Fix for issue 304: symupload needs to support timeout specifications(wininet can timeout when sending large symbol files).
...
R=doshimun
W=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@319 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-20 19:02:12 +00:00
mmentovai
bbd9b47291
The string buffer lengths in a URL_COMPONENTS structure are in TCHARs, so
...
these should be sizeof(z) / sizeof(z[0]) to avoid a buffer overrun. Caught
by Dmitry Titov, r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@229 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-13 22:17:14 +00:00
mmentovai
f2fa084fd2
Fix compiler warning C4245: signed/unsigned mismatch when converting between
...
types. Patch by Sorin Jianu. r=me,bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@217 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 16:27:56 +00:00
bryner
28c645f3ee
Silences warning C4701: local variable 'claimed_size' may be used with out
...
having been initialized. The code is correct however the compiler can't see
the relationship between has_content_length_header and the claimed_size so it
generates a warning.
Patch from Sorin Jianu, r=bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@211 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-20 21:48:47 +00:00
ted.mielczarek
684649a571
Issue 42 - check for non-existent dump file in HTTPUpload::SendRequest. r=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@186 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-01 11:47:28 +00:00
mmentovai
30fc9ce1c0
Replace GB_WSU_SAFE_SWPRINTF_TERMINATE with inline code ( #145 followup).
...
r=bryner
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/f77da3d219cf9388
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@140 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-04 16:13:55 +00:00
mmentovai
1de8bed899
Windows http_upload should allow response without Content-Length header ( #144 ).
...
Patch by Ted Mielczarek. r=me
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/a401434f639e5b2f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@136 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-02 18:24:16 +00:00
mmentovai
aec44489da
vswprintf causes Purify to fail ( #145 ). r=darin
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/88e18d9fac4eee22
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@135 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-30 20:30:08 +00:00
mmentovai
e5dc60822e
Rename Airbag to Breakpad.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@122 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-14 19:51:05 +00:00
incrementalist
d4e527b7ee
Allows the caller of CrashReportSender::SendCrashReport() to determine that
...
the server rejected a crash report, by changing the return value from a
boolean to a tri-state enum.
Fixes issue #101 . Reviewed by mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@99 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-03 23:14:46 +00:00
incrementalist
dd7c38baae
This patch fixes Airbag issue #44 .
...
Summary of this patch:
* It adds a new wstring* parameter to the end of both
SendCrashReport() and HTTPUpload::SendRequest(), which can be NULL.
* If the request isn't successful, the result parameter isn't touched.
* It adds HTTPUpload::UTF8ToWide() to allow the response to be
returned as a wstring,
* It changes the return value of SendRequest (and by extension,
SendCrashReport) so that if the size of the response body isn't
exactly the same as the value given in the Content-Length header, the
return value is false (in addition to the previous semantics).
* It also updates symupload.cc to account for the new parameter in
SendRequest().
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@81 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-08 20:45:20 +00:00
bryner
c297c50f83
Fix a crash when attempting to upload a zero-length dump file ( #83 ) r=mmentovai
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@71 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-27 18:38:39 +00:00
mmentovai
73cd14b4af
Airbag client libraries should compile under MSVC .NET 2003/7.1 ( #64 ).
...
r=bryner
http://groups.google.com/group/airbag-dev/browse_thread/thread/b838faeb50f71818
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@64 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-15 22:24:42 +00:00
mmentovai
12a5245bfe
Disable exception handling warnings in Windows client code ( #38 ).
...
Patch by Ted Mielczarek. r=me
http://groups.google.com/group/airbag-dev/browse_thread/thread/133814673f75d5fa
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@56 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-27 19:47:21 +00:00
mmentovai
29401d2457
Support building with WIN32_LEAN_AND_MEAN ( #60 )
...
- All Windows code now builds with WIN32_LEAN_AND_MEAN by default.
- Header inclusion is adjusted as needed.
Remove use of UuidToString (#39 )
- Also breaks dependency on RpcStringFree and therefore rpcrt4.lib.
r=bryner
http://groups.google.com/group/airbag-dev/browse_thread/thread/30f844cfc7ccd37f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@51 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-26 18:06:43 +00:00
mmentovai
5afd60b067
Improvements for Windows client/tool-side code. r=bryner
...
- Allow Windows sender to use https (#41 ).
- HTTPUpload not proxy-friendly (#46 ).
- Check http status codes (sort of #44 ).
- Allow symupload to work with versionless files (prints a warning, server
may still reject).
http://groups.google.com/group/airbag-dev/browse_thread/thread/5a12a72dffc5999c
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@41 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-19 21:48:51 +00:00
bryner
8b1645d8cd
Implement a tool to upload symbols on Windows, given an exe or dll file with
...
debugging info. Refactor common code into HTTPUpload so that the multipart
POST request code can be shared with CrashReportSender. #47
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@39 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-16 17:27:03 +00:00