Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2025-12-25 16:54:43 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Issue 49013: Breakpad Processor: Use a separate API to retrieve Windows stack debugging info.

Browse source 
At the moment, FillSourceLineInfo returns Windows DIA-based stack
walking data. In addition to being ugly, this makes it difficult to
provide access to DWARF CFI-based stack walking data in a symmetrical
way.

This patch changes FillSourceLineInfo to do the single job its name
suggests, and adds a second member function to
SourceLineResolverInterface to retrieve Windows DIA stack walking
information. A sibling member function will provide access to DWARF
CFI stack walking data.

a=jimblandy, r=mmentovai


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@480 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
jimblandy 2010-01-11 22:31:50 +00:00
parent 5b787b1911
commit e9faf54828
5 changed files with 103 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/processor/stackwalker.cc
View file

@ -118,7 +118,8 @@ bool Stackwalker::Walk(CallStack *stack) {
return false;
}
}
frame_info.reset(resolver_->FillSourceLineInfo(frame.get()));
resolver_->FillSourceLineInfo(frame.get());
frame_info.reset(resolver_->FindWindowsFrameInfo(frame.get()));
}
}