Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-01-09 07:58:24 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleaning up google-breakpad source code of signed-unsigned comparison warnings

Browse source 
http://breakpad.appspot.com/488002/



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1083 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
ivan.penkov@gmail.com 2012-11-21 01:33:08 +00:00
parent d80f175c1a
commit c937b0ee01
30 changed files with 188 additions and 182 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/tools/linux/md2core/minidump-2-core.cc
View file

@ -675,7 +675,7 @@ ParseDSODebugInfo(CrashedProcess* crashinfo, const MinidumpMemoryRange& range,
range.length() - sizeof(MDRawDebug));
}
if (debug->map != kInvalidMDRVA) {
for (int i = 0; i < debug->dso_count; ++i) {
for (unsigned int i = 0; i < debug->dso_count; ++i) {
const MDRawLinkMap* link_map =
full_file.GetArrayElement<MDRawLinkMap>(debug->map, i);
if (link_map) {

14
src/tools/linux/md2core/minidump_memory_range_unittest.cc
View file

@ -95,7 +95,7 @@ const size_t kNumElements = sizeof(kElements) / sizeof(kElements[0]);
TEST(MinidumpMemoryRangeTest, DefaultConstructor) {
MinidumpMemoryRange range;
EXPECT_EQ(NULL, range.data());
EXPECT_EQ(0, range.length());
EXPECT_EQ(0U, range.length());
}
TEST(MinidumpMemoryRangeTest, ConstructorWithDataAndLength) {
@ -108,7 +108,7 @@ TEST(MinidumpMemoryRangeTest, Reset) {
MinidumpMemoryRange range;
range.Reset();
EXPECT_EQ(NULL, range.data());
EXPECT_EQ(0, range.length());
EXPECT_EQ(0U, range.length());
range.Set(kBuffer, kBufferSize);
EXPECT_EQ(kBufferPointer, range.data());
@ -116,7 +116,7 @@ TEST(MinidumpMemoryRangeTest, Reset) {
range.Reset();
EXPECT_EQ(NULL, range.data());
EXPECT_EQ(0, range.length());
EXPECT_EQ(0U, range.length());
}
TEST(MinidumpMemoryRangeTest, Set) {
@ -127,14 +127,14 @@ TEST(MinidumpMemoryRangeTest, Set) {
range.Set(NULL, 0);
EXPECT_EQ(NULL, range.data());
EXPECT_EQ(0, range.length());
EXPECT_EQ(0U, range.length());
}
TEST(MinidumpMemoryRangeTest, SubrangeOfEmptyMemoryRange) {
MinidumpMemoryRange range;
MinidumpMemoryRange subrange = range.Subrange(0, 10);
EXPECT_EQ(NULL, subrange.data());
EXPECT_EQ(0, subrange.length());
EXPECT_EQ(0U, subrange.length());
}
TEST(MinidumpMemoryRangeTest, SubrangeAndGetData) {
@ -157,7 +157,7 @@ TEST(MinidumpMemoryRangeTest, SubrangeAndGetData) {
EXPECT_FALSE(range.Covers(sub_offset, sub_length));
EXPECT_EQ(NULL, range.GetData(sub_offset, sub_length));
EXPECT_EQ(NULL, subrange.data());
EXPECT_EQ(0, subrange.length());
EXPECT_EQ(0U, subrange.length());
}
}
}
@ -185,7 +185,7 @@ TEST(MinidumpMemoryRangeTest, SubrangeWithMDLocationDescriptor) {
EXPECT_FALSE(range.Covers(sub_offset, sub_length));
EXPECT_EQ(NULL, range.GetData(sub_offset, sub_length));
EXPECT_EQ(NULL, subrange.data());
EXPECT_EQ(0, subrange.length());
EXPECT_EQ(0U, subrange.length());
}
}
}