Change the way function and public symbols are obtained to use the findChildren DIA function.

Browse source

This has a substantial performance improvement over using the getSymbolsByAddr iterator, especially on certain 64bit DLLS.  e.g. Time to process chrome_child.dll drops from 51 minutes to 21 secs.

Note: new test data looks different because the ordering of lines is no longer by memory address.  This does not affect processing.  The test data has been manually compared to old data and matches (except additional PUBLIC symbols).  Also, INFO lines are omitted because the source executable files are not checked in, so they are unavailable.

R=ivanpe@chromium.org, mark@chromium.org

Review URL: https://breakpad.appspot.com/1574002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1316 4c0a9323-5329-0410-9bdc-e9ce6186880e

...

This commit is contained in:

wfh@chromium.org 2014-04-16 22:50:28 +00:00

parent 7cc286a5a7

commit c83a81450c

7 changed files with 14694 additions and 13740 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4012

src/tools/windows/dump_syms/testdata/dump_syms_regtest.sym vendored

View file

File diff suppressed because it is too large Load diff

6249

src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym vendored

View file

File diff suppressed because it is too large Load diff

5810

src/tools/windows/dump_syms/testdata/omap_reorder_bbs.sym vendored

View file

File diff suppressed because it is too large Load diff

4012

src/tools/windows/dump_syms/testdata/omap_reorder_funcs.sym vendored

View file

File diff suppressed because it is too large Load diff

4254

src/tools/windows/dump_syms/testdata/omap_stretched.sym vendored

View file

File diff suppressed because it is too large Load diff

4012

src/tools/windows/dump_syms/testdata/omap_stretched_filled.sym vendored

View file

File diff suppressed because it is too large Load diff