Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2025-12-31 03:37:44 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Issue 49012: Breakpad Processor: Rename 'StackFrameInfo' structure to 'WindowsFrameInfo'.

Browse source 
Also, rename stack_frame_info.h to windows_frame_info.h.

If it seems odd to have functions like FillSourceLineInfo returning
Windows-specific data structures... well, it is! This patch just makes
it more obvious what's going on.

a=jimblandy, r=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@471 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
jimblandy 2009-12-23 22:32:14 +00:00
parent 92b1f834d1
commit b64d76a3b8
19 changed files with 55 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/google_breakpad/processor/basic_source_line_resolver.h
View file

@ -63,7 +63,7 @@ class BasicSourceLineResolver : public SourceLineResolverInterface {
virtual bool HasModule(const string &module_name) const;
virtual StackFrameInfo* FillSourceLineInfo(StackFrame *frame) const;
virtual WindowsFrameInfo* FillSourceLineInfo(StackFrame *frame) const;
private:
template<class T> class MemAddrMap;

6
src/google_breakpad/processor/source_line_resolver_interface.h
View file

@ -40,7 +40,7 @@ namespace google_breakpad {
using std::string;
struct StackFrame;
struct StackFrameInfo;
struct WindowsFrameInfo;
class SourceLineResolverInterface {
public:
@ -68,9 +68,9 @@ class SourceLineResolverInterface {
// module_name fields must already be filled in. Additional debugging
// information, if available, is returned. If the information is not
// available, returns NULL. A NULL return value does not indicate an
// error. The caller takes ownership of any returned StackFrameInfo
// error. The caller takes ownership of any returned WindowsFrameInfo
// object.
virtual StackFrameInfo* FillSourceLineInfo(StackFrame *frame) const = 0;
virtual WindowsFrameInfo* FillSourceLineInfo(StackFrame *frame) const = 0;
protected:
// SourceLineResolverInterface cannot be instantiated except by subclasses

4
src/google_breakpad/processor/stackwalker.h
View file

@ -53,7 +53,7 @@ class MemoryRegion;
class MinidumpContext;
class SourceLineResolverInterface;
struct StackFrame;
struct StackFrameInfo;
struct WindowsFrameInfo;
class SymbolSupplier;
class SystemInfo;
@ -135,7 +135,7 @@ class Stackwalker {
// the caller.
virtual StackFrame* GetCallerFrame(
const CallStack *stack,
const vector< linked_ptr<StackFrameInfo> > &stack_frame_info) = 0;
const vector< linked_ptr<WindowsFrameInfo> > &stack_frame_info) = 0;
// The optional SymbolSupplier for resolving source line info.
SymbolSupplier *supplier_;