Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-01-01 20:24:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make x86-64 stack walking work for Native Client minidumps

Browse source 
For NaCl, a stack walker should ignore the top 32 bits of %rip, %rsp
and %rbp, otherwise it will try to read from %r15-extended stack
addresses and look up symbol info for %r15-extended code addresses,
which will fail.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST=tested manually with a NaCl minidump

Review URL: https://breakpad.appspot.com/591002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1173 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
mseaborn@chromium.org 2013-05-08 02:37:15 +00:00
parent 85c352695f
commit b45b97b2fd
2 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/google_breakpad/processor/system_info.h
View file

@ -63,10 +63,11 @@ struct SystemInfo {
string os;
// A short form of the os string, using lowercase letters and no spaces,
// suitable for use in a filesystem. Possible values are "windows",
// "mac", and "linux". Empty if the information is not present in the dump
// or if the OS given by the dump is unknown. The values stored in this
// field should match those used by MinidumpSystemInfo::GetOS.
// suitable for use in a filesystem. Possible values include "windows",
// "mac", "linux" and "nacl". Empty if the information is not present
// in the dump or if the OS given by the dump is unknown. The values
// stored in this field should match those used by
// MinidumpSystemInfo::GetOS.
string os_short;
// A string identifying the version of the operating system, such as