Add MD_OS_ANDROID definition.

In order to better distinguish Android and Linux minidumps, introduce
a new MD_OS_ANDROID definition, and modify related source code accordingly.

Also append the build-fingerprint to the minidump location descriptor.
This gives more information about the system image the device runs on.
Review URL: https://breakpad.appspot.com/405002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@981 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
digit@chromium.org 2012-07-04 11:56:26 +00:00
parent 7db2fb7b93
commit 8d96707553
5 changed files with 38 additions and 1 deletions

View file

@ -79,6 +79,7 @@ Exploitability *Exploitability::ExploitabilityForPlatform(
case MD_OS_LINUX:
case MD_OS_UNIX:
case MD_OS_SOLARIS:
case MD_OS_ANDROID:
default: {
platform_exploitability = NULL;
break;

View file

@ -1760,6 +1760,7 @@ string MinidumpModule::code_identifier() const {
case MD_OS_MAC_OS_X:
case MD_OS_IOS:
case MD_OS_SOLARIS:
case MD_OS_ANDROID:
case MD_OS_LINUX: {
// TODO(mmentovai): support uuid extension if present, otherwise fall
// back to version (from LC_ID_DYLIB?), otherwise fall back to something
@ -3108,6 +3109,10 @@ string MinidumpSystemInfo::GetOS() {
os = "solaris";
break;
case MD_OS_ANDROID:
os = "android";
break;
default:
BPLOG(ERROR) << "MinidumpSystemInfo unknown OS for platform " <<
HexString(system_info_.platform_id);

View file

@ -401,6 +401,11 @@ bool MinidumpProcessor::GetOSInfo(Minidump *dump, SystemInfo *info) {
break;
}
case MD_OS_ANDROID: {
info->os = "Android";
break;
}
default: {
// Assign the numeric platform ID into the OS string.
char os_string[11];
@ -838,6 +843,7 @@ string MinidumpProcessor::GetCrashReason(Minidump *dump, u_int64_t *address) {
break;
}
case MD_OS_ANDROID:
case MD_OS_LINUX: {
switch (exception_code) {
case MD_EXCEPTION_CODE_LIN_SIGHUP: