Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-01-02 12:44:38 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

iOS: disable using CFI in stackwalking

Browse source 
dump_syms produces incomplete CFI info on iOS because it doesn't support
converting compact unwind to Breakpad symbols. Attempting to use
incomplete CFI can result in infinte stack traces.

Bug: google-breakpad:764
Change-Id: Id042aa515d17928cb5503a79038607d95c56238d
Reviewed-on: https://chromium-review.googlesource.com/1128252
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
This commit is contained in:
Joshua Peraza 2018-07-06 13:22:17 -07:00
parent 79ba6a494f
commit 89e7a8615f
2 changed files with 15 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/processor/stackwalker_arm_unittest.cc
View file

@ -782,8 +782,12 @@ TEST_F(CFI, RejectBadExpressions) {
class StackwalkerARMFixtureIOS : public StackwalkerARMFixture {
public:
StackwalkerARMFixtureIOS() {
system_info.os = "iOS";
system_info.os_short = "ios";
// iOS_test is used instead of iOS because the stackwalker has a check to
// avoid using CFI for iOS dumps. This is a workaround for bad CFI being
// produced by dump_syms for iOS.
// https://bugs.chromium.org/p/google-breakpad/issues/detail?id=764
system_info.os = "iOS_test";
system_info.os_short = "ios_test";
}
};