Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-01-10 00:18:27 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

dump_syms: Reintroduce warnings inadvertently removed by 47cd498384

Browse source 
Previously, dump_syms produced warnings whenever a DW_AT_specification
or DW_AT_abstract_origin attribute was a forward reference. 47cd498384
allowed those attributes to carry forward references, removing the
warnings altogether. It was not correct to remove the warnings entirely.
References that do not point to valid DIEs should still produce
warnings, whether a back reference or a forward reference.

This reintroduces those warnings as appropriate.

Bug: google-breakpad:813
Test: dumper_unittest SimpleCU.UnknownAbstractOrigin,Specifications.BadOffset
Change-Id: Ie7222c7a1886bab31423f27e2fbcce93e69625b3
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2090103
Reviewed-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Mark Mentovai 2020-03-06 10:40:39 -05:00
parent c7522272ff
commit 52b33b2a4b
2 changed files with 25 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
default.xml
View file

@ -32,7 +32,7 @@
<project path='src/src/third_party/lss'
name='linux-syscall-support/'
revision='8048ece6c16c91acfe0d36d1d3cc0890ab6e945c'
revision='f70e2f1641e280e777edfdad7f73a2cfa38139c7'
remote='chromium' />
<project path='src/src/third_party/protobuf/protobuf'