Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2025-12-31 11:44:48 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

linux, client: set module name from DT_SONAME

Browse source 
3e56ef9d changed dump_syms to set the module name from DT_SONAME
expecting that clients were already using DT_SONAME when it was
present. The Breakpad client previously only used DT_SONAME as the name
for a module if it detected that it was likely mapped from a zip file.
This patch updates the Breakpad Linux client to always use the
DT_SONAME in minidumps if it's present.

Also included are changes to address comments that were missed from
that review.

Bug: 1016924
Change-Id: I4aae8c05e6793d4b0598049a8964ddd4cb0c6194
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1889231
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Joshua Peraza 2019-10-29 17:55:54 -07:00 • committed by Mike Frysinger
parent d27fd9ae7e
commit 5085b1d0df
2 changed files with 32 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/common/linux/dump_symbols.cc
View file

@ -963,13 +963,11 @@ bool InitModuleForElfClass(const typename ElfClass::Ehdr* elf_header,
return false;
}
string name;
char name_buf[NAME_MAX];
memset(name_buf, 0, sizeof(name_buf));
name = google_breakpad::ElfFileSoNameFromMappedFile(elf_header, name_buf,
sizeof(name_buf))
? name_buf
: google_breakpad::BaseName(obj_filename);
char name_buf[NAME_MAX] = {};
std::string name = google_breakpad::ElfFileSoNameFromMappedFile(
elf_header, name_buf, sizeof(name_buf))
? name_buf
: google_breakpad::BaseName(obj_filename);
// Add an extra "0" at the end. PDB files on Windows have an 'age'
// number appended to the end of the file identifier; this isn't