Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2025-12-24 16:24:52 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

linux_core_dumper: partially disable test on Android

Browse source 
Running this test on android-kitkat-arm-rel fails for some reason:
[ RUN      ] LinuxCoreDumperTest.VerifyExceptionDetails
linux_core_dumper_unittest.cc:170: Failure
Expected: (0U) != (dumper.crash_address()), actual: 0 vs 0
linux_core_dumper_unittest.cc:178: Failure
Expected equality of these values:
  2U
    Which is: 2
  info.size()
    Which is: 0
[  FAILED  ] LinuxCoreDumperTest.VerifyExceptionDetails (7 ms)

Disable it for now on Android until someone can look into it.

Bug: google-breakpad:791
Change-Id: I40a5e3dbeeb44e5eb0df187e61d55e07d8ad3613
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1546778
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Mike Frysinger 2019-03-31 05:57:52 -04:00
parent 9e9e236c82
commit 4d550cceca
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/client/linux/minidump_writer/linux_core_dumper_unittest.cc
View file

@ -166,6 +166,15 @@ TEST(LinuxCoreDumperTest, VerifyExceptionDetails) {
EXPECT_TRUE(dumper.IsPostMortem());
#if defined(__ANDROID__)
// TODO: For some reason, Android doesn't seem to pass this.
if (!dumper.crash_address()) {
fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is "
"skipped due to missing signal details on Android");
return;
}
#endif
// Check the exception details.
EXPECT_NE(0U, dumper.crash_address());
EXPECT_EQ(kCrashSignal, dumper.crash_signal());