Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-01-03 13:14:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Automatically capture debugID in Mac OS symupload tool.

Browse source 
There's no need to pass in debug ID to symupload for native symbol
uploads, as breakpad can extra the ID itself for dsym and macho types.

Change-Id: Ib0b7703eac85bc84fe1f095e678d75b347bd872a
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2724731
Reviewed-by: Nelson Billing <nbilling@google.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Justin Cohen 2021-03-02 13:45:50 -05:00 • committed by Nelson Billing
parent 778bd12f22
commit 46f4b593ee
4 changed files with 214 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/common/mac/dump_syms.cc
View file

@ -285,6 +285,11 @@ SuperFatArch* DumpSymbols::FindBestMatchForArchitecture(
string DumpSymbols::Identifier() {
FileID file_id(object_filename_.c_str());
unsigned char identifier_bytes[16];
scoped_ptr<Module> module;
if (!selected_object_file_) {
if (!CreateEmptyModule(module))
return string();
}
cpu_type_t cpu_type = selected_object_file_->cputype;
cpu_subtype_t cpu_subtype = selected_object_file_->cpusubtype;
if (!file_id.MachoIdentifier(cpu_type, cpu_subtype, identifier_bytes)) {

7
src/common/mac/dump_syms.h
View file

@ -122,6 +122,9 @@ class DumpSymbols {
// module object and must delete it when finished.
bool ReadSymbolData(Module** module);
// Return an identifier string for the file this DumpSymbols is dumping.
std::string Identifier();
private:
// Used internally.
class DumperLineToModule;
@ -133,10 +136,6 @@ class DumpSymbols {
SuperFatArch* FindBestMatchForArchitecture(
cpu_type_t cpu_type, cpu_subtype_t cpu_subtype);
// Return an identifier string for the file this DumpSymbols is dumping.
std::string Identifier();
// Creates an empty module object.
bool CreateEmptyModule(scoped_ptr<Module>& module);