Always emit a 32-bit crash address for 32-bit architectures

Browse source

Certain minidumps for 32-bit crashes have the upper 32-bit of the crash
address (which is a 64-bit value) set to non-zero values. This caused a
crash address with more than 32-bits to be printed out for minidumps of
32-bit architectures. This patch masks out those bits when reading the
raw minidump data to ensure this doesn't happen anymore.

Bug: google-breakpad:783

Change-Id: Ieef6dff759fd0ee2efc47c4c4a3cf863a48f0659
Reviewed-on: https://chromium-review.googlesource.com/c/1427819
Reviewed-by: Ted Mielczarek <ted.mielczarek@gmail.com>

...

This commit is contained in:

Gabriele Svelto 2019-01-30 09:26:07 +01:00

parent 13b234ce24

commit 44384d80b3

3 changed files with 56 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

BIN

src/processor/testdata/minidump_32bit_crash_addr.dmp vendored Normal file

View file

Binary file not shown.