Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2025-12-30 03:04:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Undo suspend/resume feature since it was meant as a workaround to a bug in how we handled child process exceptions. Currently we don't return to the kernel when we take an exception from a child process, causing a hang. Now we return KERN_FAILURE, indicating to the kernel to move on to the host-level exception handler(usually Crash Reporter)

Browse source 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@292 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
nealsid 2008-10-27 04:52:16 +00:00
parent 32441cc060
commit 3a283d8f8b
2 changed files with 20 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/client/mac/handler/exception_handler.h
View file

@ -114,21 +114,6 @@ class ExceptionHandler {
static bool WriteMinidump(const string &dump_path, MinidumpCallback callback,
void *callback_context);
// Temporarily stop this class from receiving exceptions
// Returns true if exception handling was successfully suspended
// It's an error to call this function if exception handling is
// not installed(we return false)
bool SuspendExceptionHandling();
// Resume this class from receiving exceptions
// Returns true if exception handling was successfully resumed
// It's an error to call this function if exception handling is
// already installed
bool ResumeExceptionHandling();
// Tell caller whether we're setup to handle exceptions or not
bool ExceptionHandlerIsSuspended();
private:
// Install the mach exception handler
bool InstallHandler();