Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2025-12-28 10:15:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Let breakpad build with -Wall on OS X and Linux.

Browse source 
A=thakis@chromium.org
Original Review: https://codereview.chromium.org/1550933002/

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1554613002 .
This commit is contained in:
Lei Zhang 2015-12-29 13:42:49 -08:00
parent 1be3027941
commit 257123ca70
9 changed files with 14 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/common/linux/dump_symbols.cc
View file

@ -889,7 +889,6 @@ bool ReadSymbolDataElfClass(const typename ElfClass::Ehdr* elf_header,
const DumpOptions& options,
Module** out_module) {
typedef typename ElfClass::Ehdr Ehdr;
typedef typename ElfClass::Shdr Shdr;
*out_module = NULL;

2
src/common/linux/libcurl_wrapper.h
View file

@ -43,7 +43,7 @@ namespace google_breakpad {
class LibcurlWrapper {
public:
LibcurlWrapper();
~LibcurlWrapper();
virtual ~LibcurlWrapper();
virtual bool Init();
virtual bool SetProxy(const string& proxy_host,
const string& proxy_userpwd);

4
src/common/linux/synth_elf.cc
View file

@ -213,8 +213,10 @@ void ELF::Finish() {
SymbolTable::SymbolTable(Endianness endianness,
size_t addr_size,
StringTable& table) : Section(endianness),
addr_size_(addr_size),
table_(table) {
#ifndef NDEBUG
addr_size_ = addr_size;
#endif
assert(addr_size_ == 4 || addr_size_ == 8);
}

2
src/common/linux/synth_elf.h
View file

@ -173,7 +173,9 @@ class SymbolTable : public Section {
uint64_t size, unsigned info, uint16_t shndx);
private:
#ifndef NDEBUG
size_t addr_size_;
#endif
StringTable& table_;
};