Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-01-05 14:08:20 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing compiler warnings:

Browse source 
- Building Breakpad in Xcode with arm64 architecture.
 - iOS
Patches provided by: Ian Hickson and Greg Vance.

R=mark@chromium.org

Review URL: https://breakpad.appspot.com/1184003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1286 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
ivan.penkov@gmail.com 2014-02-28 10:21:20 +00:00
parent 70acad5df8
commit 1df13fed15
5 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/client/ios/Breakpad.mm
View file

@ -98,7 +98,7 @@ class ProtectedMemoryLocker {
: mutex_(mutex),
allocator_(allocator) {
// Lock the mutex
int rv = pthread_mutex_lock(mutex_);
__attribute__((unused)) int rv = pthread_mutex_lock(mutex_);
assert(rv == 0);
// Unprotect the memory
@ -110,7 +110,7 @@ class ProtectedMemoryLocker {
allocator_->Protect();
// Then unlock the mutex
int rv = pthread_mutex_unlock(mutex_);
__attribute__((unused)) int rv = pthread_mutex_unlock(mutex_);
assert(rv == 0);
};

6
src/client/mac/handler/minidump_generator.cc
View file

@ -1479,13 +1479,13 @@ bool MinidumpGenerator::WriteModuleListStream(
module_list_stream->stream_type = MD_MODULE_LIST_STREAM;
module_list_stream->location = list.location();
list.get()->number_of_modules = image_count;
list.get()->number_of_modules = static_cast<uint32_t>(image_count);
// Write out the executable module as the first one
MDRawModule module;
uint32_t executableIndex = FindExecutableModule();
if (!WriteModuleStream(executableIndex, &module)) {
if (!WriteModuleStream(static_cast<unsigned>(executableIndex), &module)) {
return false;
}
@ -1494,7 +1494,7 @@ bool MinidumpGenerator::WriteModuleListStream(
for (uint32_t i = 0; i < image_count; ++i) {
if (i != executableIndex) {
if (!WriteModuleStream(i, &module)) {
if (!WriteModuleStream(static_cast<unsigned>(i), &module)) {
return false;
}