Suyu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2025-12-29 02:35:31 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix potential null pointer dereference.

Browse source 
If a MinidumpLinuxMapsList was created and destroyed without its Read method,
the program would have a segmentation fault because the destructor did not
check for a null maps_ field. Additional changes include additional
supplementary null checks, a potential memory leak fix, and some comment
removal.

Review URL: https://codereview.chromium.org/1271543002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1478 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
Liu.andrew.x@gmail.com 2015-07-31 15:26:39 +00:00
parent 4634d88f2e
commit 0dbae0cf3f
2 changed files with 15 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/google_breakpad/processor/minidump.h
View file

@ -901,10 +901,6 @@ class MinidumpLinuxMaps : public MinidumpObject {
// This caller owns the pointer.
explicit MinidumpLinuxMaps(Minidump *minidump);
// Read data about a single mapping from /proc/self/maps and load the data
// into this object. The input vector is in the same format as a line from
// /proc/self/maps.
// The memory region struct that this class wraps.
MappedMemoryRegion region_;