From d43c55bcb96b14feddd0f767fdcc8ebba6363535 Mon Sep 17 00:00:00 2001 From: MarcUs7 <96580944+MarcUs7i@users.noreply.github.com> Date: Sat, 28 Dec 2024 19:43:49 +0100 Subject: [PATCH] Refactored HealthBar and the LevelCounter scripts --- Assets/game/Scripts/UI/HealthBar.cs | 5 ++--- Assets/game/Scripts/UI/LevelCounter.cs | 15 ++++++++------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Assets/game/Scripts/UI/HealthBar.cs b/Assets/game/Scripts/UI/HealthBar.cs index 2ce4c4f..f093446 100644 --- a/Assets/game/Scripts/UI/HealthBar.cs +++ b/Assets/game/Scripts/UI/HealthBar.cs @@ -8,13 +8,12 @@ public class HealthBar : MonoBehaviour public PlayerHealth playerHealth; public Slider slider; - void Start() + private void Start() { slider.maxValue = playerHealth.health; } - // Update is called once per frame - void Update() + private void Update() { slider.value = playerHealth.health; } diff --git a/Assets/game/Scripts/UI/LevelCounter.cs b/Assets/game/Scripts/UI/LevelCounter.cs index 9e7f962..4bdf36d 100644 --- a/Assets/game/Scripts/UI/LevelCounter.cs +++ b/Assets/game/Scripts/UI/LevelCounter.cs @@ -4,21 +4,22 @@ using UnityEngine; public class LevelCounter : MonoBehaviour { - Animator animator; + private static readonly int FadeAnimationID = Animator.StringToHash("Fade"); + private Animator _animator; - void Start() + private void Start() { - animator = GetComponent(); - StartCoroutine(Disabeling()); + _animator = GetComponent(); + StartCoroutine(Disabling()); } - IEnumerator Disabeling() + private IEnumerator Disabling() { yield return new WaitForSeconds(2.0f); - animator.SetBool("Fade", true); + _animator.SetBool(FadeAnimationID, true); yield return new WaitForSeconds(0.1f); - animator.SetBool("Fade", false); + _animator.SetBool(FadeAnimationID, false); yield return new WaitForSeconds(1.8f); Destroy(gameObject);